style: Document & refactor rooms/alias service

src/service/rooms/alias/remote.rs

@@ -1,40 +1,42 @@
-use conduwuit::{Result, debug, error, implement};
+use conduwuit::{Result, debug, error};
 use federation::query::get_room_information::v1::Response;
 use ruma::{OwnedRoomId, OwnedServerName, RoomAliasId, ServerName, api::federation};
 
-#[implement(super::Service)]
-pub(super) async fn remote_resolve(
-	&self,
-	room_alias: &RoomAliasId,
-) -> Result<(OwnedRoomId, Vec<OwnedServerName>)> {
-	debug!("Asking {} to resolve {room_alias:?}", room_alias.server_name());
-	match self
-		.remote_request(room_alias, room_alias.server_name())
-		.await
-	{
-		| Err(e) => {
-			error!("Unable to resolve remote room alias {}: {e}", room_alias);
-			Err(e)
-		},
-		| Ok(Response { room_id, servers, .. }) => {
-			debug!("Remote resolved {room_alias:?} to {room_id:?} with servers {servers:?}");
-			Ok((room_id, servers))
-		},
+impl super::Service {
+	/// Resolves the given room alias to a room ID and a list of servers that
+	/// are in the room by asking the remote server which owns it.
+	pub(super) async fn remote_resolve(
+		&self,
+		room_alias: &RoomAliasId,
+	) -> Result<(OwnedRoomId, Vec<OwnedServerName>)> {
+		debug!("Asking {} to resolve {room_alias:?}", room_alias.server_name());
+		match self
+			.remote_request(room_alias, room_alias.server_name())
+			.await
+		{
+			| Err(e) => {
+				error!("Unable to resolve remote room alias {}: {e}", room_alias);
+				Err(e)
+			},
+			| Ok(Response { room_id, servers, .. }) => {
+				debug!("Remote resolved {room_alias:?} to {room_id:?} with servers {servers:?}");
+				Ok((room_id, servers))
+			},
+		}
+	}
+
+	async fn remote_request(
+		&self,
+		room_alias: &RoomAliasId,
+		server: &ServerName,
+	) -> Result<Response> {
+		use federation::query::get_room_information::v1::Request;
+
+		let request = Request::new(room_alias.to_owned());
+
+		self.services
+			.sending
+			.send_federation_request(server, request)
+			.await
 	}
 }
-
-#[implement(super::Service)]
-async fn remote_request(
-	&self,
-	room_alias: &RoomAliasId,
-	server: &ServerName,
-) -> Result<Response> {
-	use federation::query::get_room_information::v1::Request;
-
-	let request = Request::new(room_alias.to_owned());
-
-	self.services
-		.sending
-		.send_federation_request(server, request)
-		.await
-}