fix: Correct roomuserid_lastnotificationread table alias

roomuserid_lastnotificationread was mapped to userroomid_highlightcount
instead of its own table, so last_notification_read() read the highlight
count and reset_notification_counts clobbered the highlight table when
setting a read marker. Add the missing table definition and fix the alias.

changelog.d/+a3260bd06.bugfix.md

@@ -0,0 +1 @@
+Fixed `roomuserid_lastnotificationread` being aliased to the highlight count table, which clobbered highlight counts when setting a read marker. Contributed by @eleboucher

src/database/maps.rs

@@ -478,6 +478,10 @@ pub(super) static MAPS: &[Descriptor] = &[
 		name: "logintoken_expiresatuserid",
 		..descriptor::RANDOM_SMALL
 	},
+	Descriptor {
+		name: "roomuserid_lastnotificationread",
+		..descriptor::RANDOM
+	},
 	Descriptor {
 		name: "userroomid_highlightcount",
 		..descriptor::RANDOM

src/service/rooms/user/mod.rs

@@ -27,7 +27,8 @@ impl crate::Service for Service {
 			db: Data {
 				userroomid_notificationcount: args.db["userroomid_notificationcount"].clone(),
 				userroomid_highlightcount: args.db["userroomid_highlightcount"].clone(),
-				roomuserid_lastnotificationread: args.db["userroomid_highlightcount"].clone(),
+				roomuserid_lastnotificationread: args.db["roomuserid_lastnotificationread"]
+					.clone(),
 			},
 			services: Services {
 				globals: args.depend::<globals::Service>("globals"),