f0533e07ef
fed: remove unnecessary mutables, use with_capacity in couple more places
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-06-02 23:53:31 -04:00
68f42f5a2f
fed: relax read receipt EDU check
...
so in theory: guest users, peaking over federation,
and world readable rooms should be allowed to send
read receipts even if they're not joined.
relaxing this check to only allow the read receipt if
the server has at least 1 member in the room makes
some of this still work
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-06-02 23:53:31 -04:00
4aead5de7a
reflax a couple restrictions on custom room IDs and aliases
...
🙃
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-06-02 23:53:31 -04:00
887496d040
consolidate default cargo features
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 23:01:12 +00:00
c2586737ae
accept receipts prior to events
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 23:01:12 +00:00
102bd1b4a6
use debug_warn for parse_incoming_pdu err results.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 23:01:12 +00:00
90d9a997a5
split / cleanup core utils.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 20:17:45 +00:00
5fe5ab279c
split RouterExt impl related into ruma_wrapper unit.
...
slightly restrict client_server mod index.
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 20:17:45 +00:00
68cbf19154
Fix items-after-statements
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 12:34:05 -04:00
02081b66c4
Fix some unnecessary-unwraps w/ addl cleanup/simplification.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 12:34:05 -04:00
b3fc8516ed
Fix unnested-or-patterns
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 12:34:05 -04:00
eed8a2a801
add and sort incomplete package metadata
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-06-02 12:34:05 -04:00
a41a60ef07
media: dont ignore requested filename on /download for Content-Disposition
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
b94045a468
dissolve key_value/*
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
3122648767
split ruma_wrapper from_request() related.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
3f5349ad76
simplify RumaHandler for Router building.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
27dcf213f1
tweak error strings.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
a1b526b3b7
tweak log levels
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
dc614e11d6
check invite target is our server.
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
c5569b4c6e
dedup acl checks
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
71a1285c7b
hoist receipt ACL check
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-27 18:16:23 -04:00
abdda6cf32
check invited user's server against ACLs on /invite
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
4d21f9d962
use ok_or_else instead of ok_or for function calls in server_server.rs
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
1013fe5a42
check for membership join state at /send_join
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
f31b7b9420
ignore inbound EDUs for users that dont belong to origin server
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
e5e358cc68
compare X-Matrix origin + body origin and check PDU/EDU length at /send txn
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
50bc7cc005
check state_key matches sender user at /send_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
445015e9ea
check user ID server against ACLs at /send_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
7a38c12e5d
check for member event type at /send_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
2a77951152
check for membership leave state at /send_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
0256c27363
check if we know about room at /make_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
826edc0a3a
check state_key matches sender user at /send_join
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
a5043a38e1
only allow membership event types at /send_join
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
bfd471a863
check user ID server against ACLs for /send_join
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
3981e77ec6
check user ID server against ACLs for /make_join
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
81bf4b7150
check user ID server against ACLs for /make_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
b8ec763a7c
ignore read receipts from ACL'd servers and users not joined
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
003d4edbfa
debug log receiving typing EDUs for users not in room
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
4f0006d18a
ignore typing EDUs from ACL'd user's servers
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
7328ed7509
rename misleading sender_servername to origin
...
this is the X-Matrix origin/server, NOT the `"sender"``
user's server name.
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-27 18:16:23 -04:00
6269822613
actually fix all let_underscore_must_use lints
...
CI caught some more
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
dc9fe657d5
fix guest accounts being logged still
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
1c7c5bc09c
feat: add /_conduwuit/local_user_count endpoint
...
only enabled if federation is enabled
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
32161801ed
use/enable let_underscore_must_use lint
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
e098448b9d
init a few vecs in event_handler using with_capacity
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
cb73ae3732
add registration token validity endpoint as per matrix 1.2
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
06bec40591
fix: add missing fetch_required_signing_keys for remote send_leave
...
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
9a7ba94ccf
explicity define unstable support for sliding sync
...
this matrix-react-sdk PR (and the cited sliding sync MSC)
says that they will intend on checking sliding sync support
from this unstable feature flag at /versions until the CORS
header stuff is specced
https://github.com/matrix-org/matrix-react-sdk/pull/12498
Signed-off-by: strawberry <strawberry@puppygock.gay >
2024-05-25 22:28:43 -04:00
6c1434c165
Hot-Reloading Refactor
...
Signed-off-by: Jason Volk <jason@zemos.net >
2024-05-21 20:22:17 -04:00
9eb0784f6f
don't return extra member count or e2ee device updates from sync
...
Previously, we were returning redundant member count updates or encrypted
device updates from the /sync endpoint in some cases. The extra member
count updates are spec-compliant, but unnecessary, while the extra
encrypted device updates violate the spec.
The refactor necessary to fix this bug is also necessary to support
filtering on state events in sync.
Details:
Joined room incremental sync needs to examine state events for four
purposes:
1. determining whether we need to return an update to room member counts
2. determining the set of left/joined devices for encrypted rooms
(returned in `device_lists`)
3. returning state events to the client (in `rooms.joined.*.state`)
4. tracking which member events we have sent to the client, so they can
be omitted on future requests when lazy-loading is enabled.
The state events that we need to examine for the first two cases is member
events in the delta between `since` and the end of `timeline`. For the
second two cases, we need the delta between `since` and the start of
`timeline`, plus contextual member events for any senders that occur in
`timeline`. The second list is subject to filtering, while the first is
not.
Before this change, we were using the same set of state events that we are
returning to the client (cases 3/4) to do the analysis for cases 1/2.
In a compliant implementation, this would result in us missing some
relevant member events in 1/2 in addition to seeing redundant member
events. In current conduwuit this is not the case because the set of
events that we return to the client is always a superset of the set that
is needed for cases 1/2. This is because we don't support filtering, and
we have an existing bug[1] where we are returning the delta between
`since` and the end of `timeline` rather than the start.
[1]: https://github.com/girlbossceo/conduwuit/issues/361
Fixing this is necessary to implement filtering because otherwise
we would start missing some member events for member count or encrypted
device updates if the relevant member events are rejected by the filter.
This would be much worse than our current behavior.
2024-05-20 20:55:56 -04:00
strawberry
Jason Volk
Benjamin Lee