fix: un-forget how streams work

src/service/rooms/event_handler/handle_incoming_pdu.rs

@@ -15,7 +15,6 @@ use ruma::{
 		room::member::{MembershipState, RoomMemberEventContent},
 	},
 };
-use serde_json::{json, value::to_raw_value};
 
 use crate::rooms::timeline::{RawPduId, pdu_fits};
 
@@ -272,13 +271,8 @@ pub async fn handle_incoming_pdu<'a>(
 			"Attempting to squash extremities after upgrading pdu"
 		);
 		// Try to send a dummy event to squash extremities. See issue #1844
-		while let Some(user_id) = self
+		let mut local_users = self.services.state_cache.local_users_in_room(room_id);
-			.services
+		while let Some(user_id) = local_users.next().await {
-			.state_cache
-			.local_users_in_room(room_id)
-			.next()
-			.await
-		{
 			let state_lock = self.services.state.mutex.lock(room_id).await;
 			if self
 				.services
@@ -286,11 +280,7 @@ pub async fn handle_incoming_pdu<'a>(
 				.build_and_append_pdu(
 					PartialPdu {
 						event_type: "org.matrix.dummy_event".into(),
-						content: to_raw_value(&json!({})).expect("john json"),
+						..PartialPdu::default()
-						unsigned: None,
-						state_key: None,
-						redacts: None,
-						timestamp: None,
 					},
 					&user_id,
 					Some(room_id),