perf: Strip unsigned over federation and generate it on the fly locally

src/api/client/sync/mod.rs

@@ -7,7 +7,7 @@ use conduwuit::{
 	Event, PduCount, Result, debug_warn, err,
 	matrix::pdu::PduEvent,
 	ref_at, trace,
-	utils::stream::{BroadbandExt, ReadyExt, TryIgnore},
+	utils::stream::{BroadbandExt, ReadyExt, TryIgnore, WidebandExt},
 };
 use conduwuit_service::Services;
 use futures::StreamExt;
@@ -83,9 +83,19 @@ async fn load_timeline(
 				.pdus_rev(room_id, ending_count.map(|count| count.saturating_add(1)))
 				.ignore_err()
 				.ready_take_while(move |&(pducount, _)| pducount > starting_count)
-				.map(move |mut pdu| {
-					pdu.1.set_unsigned(Some(sender_user));
-					pdu
+				.wide_filter_map(async |mut pdu| {
+					let ctx = services
+						.rooms
+						.timeline
+						.get_unsigned_context(&pdu.1, Some(sender_user))
+						.await;
+					pdu.1.set_unsigned(
+						ctx.user_id,
+						ctx.membership,
+						ctx.prev_content,
+						ctx.redacted_because,
+					);
+					Some(pdu)
 				})
 				.then(async move |mut pdu| {
 					if let Err(e) = services
@@ -108,9 +118,19 @@ async fn load_timeline(
 				.timeline
 				.pdus_rev(room_id, ending_count.map(|count| count.saturating_add(1)))
 				.ignore_err()
-				.map(move |mut pdu| {
-					pdu.1.set_unsigned(Some(sender_user));
-					pdu
+				.wide_filter_map(async |mut pdu| {
+					let ctx = services
+						.rooms
+						.timeline
+						.get_unsigned_context(&pdu.1, Some(sender_user))
+						.await;
+					pdu.1.set_unsigned(
+						ctx.user_id,
+						ctx.membership,
+						ctx.prev_content,
+						ctx.redacted_because,
+					);
+					Some(pdu)
 				})
 				.then(async move |mut pdu| {
 					if let Err(e) = services

src/api/client/sync/v3/joined.rs

@@ -322,7 +322,12 @@ async fn build_sticky_events(
 			continue;
 		}
 
-		pdu.set_unsigned(Some(syncing_user));
+		let ctx = services
+			.rooms
+			.timeline
+			.get_unsigned_context(&pdu, Some(sync_context.syncing_user))
+			.await;
+		pdu.set_unsigned(ctx.user_id, ctx.membership, ctx.prev_content, ctx.redacted_because);
 		events.push(Event::into_format(pdu));
 	}
 

src/api/client/sync/v5.rs

@@ -1189,12 +1189,12 @@ async fn collect_sticky_events(
 
 	// MSC4480 lets us ignore the limit for a newly visible room's backlog
 	for (room_id, pdu) in backlog {
-		push_sticky_event(&mut response, sender_user, room_id, pdu);
+		push_sticky_event(services, &mut response, sender_user, room_id, pdu).await;
 	}
 
 	let mut next_batch = None;
 	for (count, room_id, pdu) in stream.into_iter().take(limit) {
-		push_sticky_event(&mut response, sender_user, room_id, pdu);
+		push_sticky_event(services, &mut response, sender_user, room_id, pdu).await;
 		next_batch = Some(count);
 	}
 
@@ -1205,13 +1205,19 @@ async fn collect_sticky_events(
 	Ok(response)
 }
 
-fn push_sticky_event(
+async fn push_sticky_event(
+	services: &Services,
 	response: &mut sync_events::v5::response::StickyEvents,
 	sender_user: &UserId,
 	room_id: OwnedRoomId,
 	mut pdu: PduEvent,
 ) {
-	pdu.set_unsigned(Some(sender_user));
+	let ctx = services
+		.rooms
+		.timeline
+		.get_unsigned_context(&pdu, Some(sender_user))
+		.await;
+	pdu.set_unsigned(ctx.user_id, ctx.membership, ctx.prev_content, ctx.redacted_because);
 	response
 		.rooms
 		.entry(room_id)