From 7352edc6e484d75876626fd3b797d5b253415f80 Mon Sep 17 00:00:00 2001 From: timedout Date: Tue, 18 Aug 2026 02:55:56 +0100 Subject: [PATCH] fix: Treat any non-ok response as a server error in sender Otherwise we never back off sending failed requests --- src/service/sending/sender.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/service/sending/sender.rs b/src/service/sending/sender.rs index 6fb402ee6..442fed288 100644 --- a/src/service/sending/sender.rs +++ b/src/service/sending/sender.rs @@ -152,8 +152,8 @@ impl Service { debug!("{dest} is now unhealthy & stale due to a connect error: {e:?}"); self.services.federation.mark_destination_stale(dest); self.services.federation.hit_unhealthy(dest.clone()); - } else if e.status_code().is_server_error() { - debug!("{dest} is now unhealthy due to server error response: {e:?}"); + } else if e.status_code() != StatusCode::OK { + debug!("{dest} is now unhealthy due to error response: {e:?}"); self.services.federation.hit_unhealthy(dest.clone()); } }