diff --git a/src/api/client/membership/knock.rs b/src/api/client/membership/knock.rs index 632b9483b..68f64c0a7 100644 --- a/src/api/client/membership/knock.rs +++ b/src/api/client/membership/knock.rs @@ -458,7 +458,6 @@ async fn knock_room_helper_local( &parsed_knock_pdu, knock_event, once(parsed_knock_pdu.event_id.borrow()), - &state_lock, room_id, ) .await?; @@ -658,7 +657,6 @@ async fn knock_room_helper_remote( &parsed_knock_pdu, knock_event, once(parsed_knock_pdu.event_id.borrow()), - &state_lock, room_id, ) .await?; diff --git a/src/service/rooms/membership/mod.rs b/src/service/rooms/membership/mod.rs index e5454fa28..6806c6a31 100644 --- a/src/service/rooms/membership/mod.rs +++ b/src/service/rooms/membership/mod.rs @@ -228,7 +228,7 @@ impl Service { // If we aren't participating in the room, or failed to join locally, // try to join over federation. - self.join_remote_room(sender_user, room_id, reason, &servers, &state_lock) + self.join_remote_room(sender_user, room_id, reason, &servers) .boxed() .await?; @@ -291,7 +291,7 @@ impl Service { PartialPdu::state(sender_user.to_string(), &content), sender_user, Some(room_id), - Some(&state_lock), + Some(state_lock), ) .await?; @@ -305,7 +305,6 @@ impl Service { room_id: &RoomId, reason: Option, servers: &[&OwnedServerName], - state_lock: &RoomMutexGuard, ) -> Result { // public so the admin command force-join-room-remotely works info!("Joining {room_id} over federation."); @@ -686,7 +685,6 @@ impl Service { &parsed_join_pdu, join_event, once(parsed_join_pdu.event_id.as_ref()), - state_lock, room_id, ) .await?; @@ -711,7 +709,7 @@ impl Service { info!("Replacing local forward extremities"); self.services .state - .set_forward_extremities(room_id, once(parsed_join_pdu.event_id()), state_lock) + .set_forward_extremities(room_id, once(parsed_join_pdu.event_id())) .await; } drop(cork); diff --git a/src/service/rooms/state/mod.rs b/src/service/rooms/state/mod.rs index 6f2892182..036c90fe0 100644 --- a/src/service/rooms/state/mod.rs +++ b/src/service/rooms/state/mod.rs @@ -413,12 +413,8 @@ impl Service { .ignore_err() } - pub async fn set_forward_extremities<'a, I>( - &'a self, - room_id: &'a RoomId, - event_ids: I, - _state_lock: &'a RoomMutexGuard, - ) where + pub async fn set_forward_extremities<'a, I>(&'a self, room_id: &'a RoomId, event_ids: I) + where I: Iterator + Send + 'a, { let prefix = (room_id, Interfix); diff --git a/src/service/rooms/timeline/append.rs b/src/service/rooms/timeline/append.rs index 332eff352..b5fbd7b95 100644 --- a/src/service/rooms/timeline/append.rs +++ b/src/service/rooms/timeline/append.rs @@ -26,8 +26,8 @@ use conduwuit_core::{ }; use futures::{FutureExt, StreamExt, TryFutureExt, pin_mut}; use ruma::{ - CanonicalJsonObject, CanonicalJsonValue, EventId, OwnedEventId, OwnedServerName, - RoomId, RoomVersionId, ServerName, UserId, + CanonicalJsonObject, CanonicalJsonValue, EventId, OwnedEventId, OwnedServerName, RoomId, + RoomVersionId, ServerName, UserId, events::{ AnySyncTimelineEvent, GlobalAccountDataEventType, TimelineEventType, push_rules::PushRulesEvent, @@ -106,12 +106,7 @@ impl super::Service { .await?; let pdu_id = self - .append_pdu( - pdu, - pdu_json, - extremities.iter().map(Borrow::borrow), - &room_id, - ) + .append_pdu(pdu, pdu_json, extremities.iter().map(Borrow::borrow), &room_id) .await?; // Process admin commands for federation events diff --git a/src/service/rooms/timeline/build.rs b/src/service/rooms/timeline/build.rs index 2e849ea04..40ae84132 100644 --- a/src/service/rooms/timeline/build.rs +++ b/src/service/rooms/timeline/build.rs @@ -134,7 +134,6 @@ impl super::Service { .iter() .map(AsRef::as_ref) .chain(once(pdu.event_id())), - state_lock, &room_id, ) .boxed()