From 5e0e82e7e82e913f5e1c0dfa3e5811781db69e75 Mon Sep 17 00:00:00 2001
From: timedout <git@nexy7574.co.uk>
Date: Fri, 26 Jun 2026 04:33:34 +0100
Subject: [PATCH] style: Document & refactor rooms/outlier service

---
 src/service/rooms/outlier/mod.rs | 44 +++++++++++++++-----------------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/src/service/rooms/outlier/mod.rs b/src/service/rooms/outlier/mod.rs
index 6ab2c026a..55a3ce7b5 100644
--- a/src/service/rooms/outlier/mod.rs
+++ b/src/service/rooms/outlier/mod.rs
@@ -24,29 +24,27 @@ impl crate::Service for Service {
 	fn name(&self) -> &str { crate::service::make_name(std::module_path!()) }
 }
 
-/// Returns the pdu from the outlier tree.
-#[implement(Service)]
-pub async fn get_outlier_pdu_json(&self, event_id: &EventId) -> Result<CanonicalJsonObject> {
-	self.db
-		.eventid_outlierpdu
-		.get(event_id)
-		.await
-		.deserialized()
-}
+impl Service {
+	/// Returns the pdu from the outlier tree.
+	pub async fn get_outlier_pdu_json(&self, event_id: &EventId) -> Result<CanonicalJsonObject> {
+		self.db
+			.eventid_outlierpdu
+			.get(event_id)
+			.await
+			.deserialized()
+	}
 
-/// Returns the pdu from the outlier tree.
-#[implement(Service)]
-pub async fn get_pdu_outlier(&self, event_id: &EventId) -> Result<PduEvent> {
-	self.db
-		.eventid_outlierpdu
-		.get(event_id)
-		.await
-		.deserialized()
-}
+	/// Returns the pdu from the outlier tree.
+	pub async fn get_pdu_outlier(&self, event_id: &EventId) -> Result<PduEvent> {
+		self.db
+			.eventid_outlierpdu
+			.get(event_id)
+			.await
+			.deserialized()
+	}
 
-/// Append the PDU as an outlier.
-#[implement(Service)]
-#[tracing::instrument(skip(self, pdu), level = "debug")]
-pub fn add_pdu_outlier(&self, event_id: &EventId, pdu: &CanonicalJsonObject) {
-	self.db.eventid_outlierpdu.raw_put(event_id, Json(pdu));
+	/// Append the PDU as an outlier.
+	pub fn add_pdu_outlier(&self, event_id: &EventId, pdu: &CanonicalJsonObject) {
+		self.db.eventid_outlierpdu.raw_put(event_id, Json(pdu));
+	}
 }