fix: Remove ability to set rocksdb as read only

src/database/engine.rs

@@ -33,7 +33,6 @@ pub struct Engine {
 	pub(crate) db: Db,
 	pub(crate) pool: Arc<Pool>,
 	pub(crate) ctx: Arc<Context>,
-	pub(super) read_only: bool,
 	pub(super) secondary: bool,
 	pub(crate) checksums: bool,
 	corks: AtomicU32,
@@ -132,7 +131,7 @@ impl Engine {
 
 	#[inline]
 	#[must_use]
-	pub fn is_read_only(&self) -> bool { self.secondary || self.read_only }
+	pub fn is_read_only(&self) -> bool { self.secondary }
 
 	#[inline]
 	#[must_use]

src/database/engine/open.rs

@@ -35,9 +35,7 @@ pub(crate) async fn open(ctx: Arc<Context>, desc: &[Descriptor]) -> Result<Arc<S
 	}
 
 	debug!("Opening database...");
-	let db = if config.rocksdb_read_only {
-		Db::open_cf_descriptors_read_only(&db_opts, path, cfds, false)
-	} else if config.rocksdb_secondary {
+	let db = if config.rocksdb_secondary {
 		Db::open_cf_descriptors_as_secondary(&db_opts, path, path, cfds)
 	} else {
 		Db::open_cf_descriptors(&db_opts, path, cfds)
@@ -55,7 +53,6 @@ pub(crate) async fn open(ctx: Arc<Context>, desc: &[Descriptor]) -> Result<Arc<S
 		db,
 		pool: ctx.pool.clone(),
 		ctx: ctx.clone(),
-		read_only: config.rocksdb_read_only,
 		secondary: config.rocksdb_secondary,
 		checksums: config.rocksdb_checksums,
 		corks: AtomicU32::new(0),