From 22c7fa1b08f9b9ff0eb85652aa07edd6e30c3599 Mon Sep 17 00:00:00 2001 From: timedout Date: Wed, 17 Jun 2026 15:36:49 +0100 Subject: [PATCH] style: Fix up some TODOs --- src/service/rooms/event_handler/fetch_prev.rs | 2 +- src/service/rooms/event_handler/fetch_state.rs | 1 - src/service/rooms/event_handler/handle_outlier_pdu.rs | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/service/rooms/event_handler/fetch_prev.rs b/src/service/rooms/event_handler/fetch_prev.rs index 5f618a66c..c36a0f3b5 100644 --- a/src/service/rooms/event_handler/fetch_prev.rs +++ b/src/service/rooms/event_handler/fetch_prev.rs @@ -88,7 +88,7 @@ impl super::Service { for (i, event_id) in to_persist.iter().enumerate() { debug!( elapsed=?start.elapsed(), - "[TODO] Persisting fetched prev event: {event_id} ({}/{})", + "Persisting fetched prev event: {event_id} ({}/{})", i.saturating_add(1), to_persist.len(), ); diff --git a/src/service/rooms/event_handler/fetch_state.rs b/src/service/rooms/event_handler/fetch_state.rs index d9908a625..198270e63 100644 --- a/src/service/rooms/event_handler/fetch_state.rs +++ b/src/service/rooms/event_handler/fetch_state.rs @@ -282,7 +282,6 @@ impl super::Service { /// state events as outliers, for use later. /// /// Any events that cannot be persisted are dropped with a warning. - /// TODO: make it noisy? pub(super) async fn fetch_full_state( &self, origin: &ServerName, diff --git a/src/service/rooms/event_handler/handle_outlier_pdu.rs b/src/service/rooms/event_handler/handle_outlier_pdu.rs index d018dd467..53d7ee9ae 100644 --- a/src/service/rooms/event_handler/handle_outlier_pdu.rs +++ b/src/service/rooms/event_handler/handle_outlier_pdu.rs @@ -170,8 +170,6 @@ impl super::Service { ))); } } - // TODO: do events received from auth chain need persisting? that - // sounds awfully slow } // 6. Reject "due to auth events" if the event doesn't pass auth based on the