fix: Address review comments

This commit is contained in:
timedout committed 2026-08-22 20:14:43 +01:00
1 parent a61cc2ac50
commit 103dafd529
1 file changed
+4 -5
+4 -5
View File
@@ -224,8 +224,7 @@ impl super::Service {
.prev_events() .prev_events()
.map(ToOwned::to_owned) .map(ToOwned::to_owned)
.stream() .stream()
.broad_filter_map(|prev_id| async move { .broad_filter_map(|prev_id| async {
let room_id = incoming_pdu.room_id_or_hash();
let (referenced, is_outlier, is_soft_failed, is_rejected) = tokio::join!( let (referenced, is_outlier, is_soft_failed, is_rejected) = tokio::join!(
self.services self.services
.pdu_metadata .pdu_metadata
@@ -248,11 +247,11 @@ impl super::Service {
incoming_pdu.prev_events().count(), incoming_pdu.prev_events().count(),
start.elapsed(), start.elapsed(),
); );
debug_assert!(!new_extremities.is_empty(), "resolved extremities cannot be empty");
if new_extremities.is_empty() { if new_extremities.is_empty() {
return Err!("Resolved extremities cannot be empty"); Err!("Resolved extremity set was empty after processing incoming event")
} else {
Ok(new_extremities.into_iter().collect())
} }
Ok(new_extremities.into_iter().collect())
} }
/// Derives a new room state by adding the incoming PDU to the state before /// Derives a new room state by adding the incoming PDU to the state before